Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENG-3617] Update the rbf logic #354

Merged
merged 23 commits into from
Feb 14, 2024
Merged

[ENG-3617] Update the rbf logic #354

merged 23 commits into from
Feb 14, 2024

Conversation

dhriaznov
Copy link
Contributor

@dhriaznov dhriaznov commented Jan 19, 2024 •
edited
Loading

🔘 PR Type

What kind of change does this PR introduce?

  • Enhancement

📜 Background

This PR adds the STX RBF logic (and also the fetching of the BTC RBF data) so that it can be reused.

Issue Link: #[ENG-3617]
Context Link (if applicable):

🔄 Changes

Does this PR introduce a breaking change?

  • Yes, Incompatible API changes
  • No, Adds functionality (backwards compatible)
  • No, Bug fixes (backwards compatible)

Changes:

  • Added the useBtcRbfTransactionData and useStxRbfTransactionData hooks

🖼 Screenshot / 📹 Video

✅ Review checklist

Please ensure the following are true before merging:

  • Code Style is consistent with the project guidelines.
  • Code is readable and well-commented.
  • No unnecessary or debugging code has been added.
  • Security considerations have been taken into account.
  • The change has been manually tested and works as expected.
  • Breaking changes and their impacts have been considered and documented.
  • Code does not introduce new technical debt or issues.

@dhriaznov dhriaznov self-assigned this Jan 19, 2024
dhriaznov and others added 14 commits January 19, 2024 17:20
@dhriaznov
Add getLatestNonce and getRawTransaction methods for stacks txs
04a5eed
@dhriaznov
Merge branch 'develop' into denys/eng-3617-speed-up-stacks-transactio…
12e472b 
…ns-on-mobile
@dhriaznov
Merge branch 'develop' into denys/eng-3617-speed-up-stacks-transactio…
861d531 
…ns-on-mobile
@dhriaznov
Add the useRbfTransactionData hook
574470e
@dhriaznov
Export the useRbfTransactionData hook
807945d
@dhriaznov
Update the useRbfTransactionData hook params
3c82079
@dhriaznov
Update the useRbfTransactionData hook params
c203b32
@dhriaznov
Update the useRbfTransactionData hook logic
920d935
@dhriaznov
Merge branch 'develop' into denys/eng-3617-speed-up-stacks-transactio…
4ae3e3a 
…ns-on-mobile
@dhriaznov
Move some logic to the separate functions, add unit tests
60e6d1c
@dhriaznov
Merge branch 'denys/eng-3617-speed-up-stacks-transactions-on-mobile' …
3c807fd 
…of github.com:secretkeylabs/xverse-core into denys/eng-3617-speed-up-stacks-transactions-on-mobile
@dhriaznov
Merge branch 'develop' into denys/eng-3617-speed-up-stacks-transactio…
85f497d 
…ns-on-mobile
@dhriaznov
Fix the imports
7f02475
@dhriaznov
Merge branch 'denys/eng-3617-speed-up-stacks-transactions-on-mobile' …
30f5f88 
…of github.com:secretkeylabs/xverse-core into denys/eng-3617-speed-up-stacks-transactions-on-mobile
@dhriaznov dhriaznov marked this pull request as ready for review January 31, 2024 23:54
teebszet
teebszet reviewed Feb 1, 2024
View reviewed changes
transactions/stx.ts Outdated Show resolved Hide resolved
@dhriaznov
Copy link
Contributor Author

I updated the PR including your suggestions folks, could you take a second look pls? @teebszet @fedeerbes

@teebszet
Copy link
Member

teebszet commented Feb 2, 2024

lgtm 😄

@teebszet teebszet added the minor label Feb 2, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 5, 2024

Test this PR with npm i --save-exact @secretkeylabs/[email protected]

@dhriaznov dhriaznov added the enhancement New feature or request label Feb 7, 2024
@fedeerbes fedeerbes merged commit 6b375dc into develop Feb 14, 2024
3 checks passed
@github-actions github-actions bot mentioned this pull request Feb 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fedeerbes fedeerbes fedeerbes left review comments

@teebszet teebszet teebszet approved these changes

Assignees

@dhriaznov dhriaznov

Labels
enhancement New feature or request minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dhriaznov @teebszet @fedeerbes